cssstaticstyle: Avoid ref'ing specified value in compute_value
authorTimm Bäder <mail@baedert.org>
Thu, 22 Aug 2019 10:14:33 +0000 (12:14 +0200)
committerTimm Bäder <mail@baedert.org>
Mon, 9 Sep 2019 15:36:24 +0000 (17:36 +0200)
There are alerady _get functions for GtkCssInheritValue and
GtkCssInitialValue, so use those. We can avoid a ref+unref pair this
way.

gtk/gtkcssstaticstyle.c

index 7f7eba14abaa2585885767050483ddc5936a2884..f2e0b1db16cabf6c59d4478b0bebe7ad38fa3e9f 100644 (file)
@@ -219,19 +219,14 @@ gtk_css_static_style_compute_value (GtkCssStaticStyle *style,
       GtkCssStyleProperty *prop = _gtk_css_style_property_lookup_by_id (id);
 
       if (_gtk_css_style_property_is_inherit (prop))
-        specified = _gtk_css_inherit_value_new ();
+        specified = _gtk_css_inherit_value_get ();
       else
-        specified = _gtk_css_initial_value_new ();
+        specified = _gtk_css_initial_value_get ();
     }
-  else
-    _gtk_css_value_ref (specified);
 
   value = _gtk_css_value_compute (specified, id, provider, (GtkCssStyle *)style, parent_style);
 
   gtk_css_static_style_set_value (style, id, value, section);
-  value = NULL;
-
-  _gtk_css_value_unref (specified);
 }
 
 GtkCssChange